Login to ZARP

TOPIC: [Release] SSRP Discord Bot

[Release] SSRP Discord Bot 4 years 5 days ago #1214247

SSRP Discord Bot - Contents removed -	bunnyslippers69 Offline Diamond Boarder Posts: 3539 Thanks received: 1186 Karma: 0
Last Edit: 3 years 9 months ago by TheXnator. The topic has been locked. The following user(s) said Thank You: Denis, slodoban milošević, JoeyRecon

[Release] SSRP Discord Bot 4 years 5 days ago #1214249

Why did u rip my first jugg man	TheFierceOwl Offline Banned ❤Finn❤ Posts: 3453 Thanks received: 541 Karma: -178
The topic has been locked.

[Release] SSRP Discord Bot 4 years 5 days ago #1214252

TheFierceOwl wrote: Why did u rip my first jugg man You were wanted vro	bunnyslippers69 Offline Diamond Boarder Posts: 3539 Thanks received: 1186 Karma: 0
The topic has been locked. The following user(s) said Thank You: TheFierceOwl

[Release] SSRP Discord Bot 4 years 5 days ago #1214254

Pretty cool feature actually.	OnionRings Offline Community Manager Posts: 10868 Thanks received: 5656 Karma: -565
The topic has been locked. The following user(s) said Thank You: bunnyslippers69

[Release] SSRP Discord Bot 4 years 5 days ago #1214269

Hi man can you please release the source code make sure to add a GitHub link your thread	Chuteuk Offline Community Owner ZARP Owner Posts: 3440 Thanks received: 5058 Karma: 956
The topic has been locked.

[Release] SSRP Discord Bot 4 years 5 days ago #1214270

Chuteuk wrote: Hi man can you please release the source code make sure to add a GitHub link your thread Yeah i'm doing that now. Give me like half an hour to clean everything up and add comments.	bunnyslippers69 Offline Diamond Boarder Posts: 3539 Thanks received: 1186 Karma: 0
The topic has been locked. The following user(s) said Thank You: Chuteuk

[Release] SSRP Discord Bot 4 years 5 days ago #1214271

Cool, gonna have a play around on my test server with it	.uzi Offline Former Community Manager Foos yer doos? Posts: 6005 Thanks received: 2441 Karma: 123
The topic has been locked.

[Release] SSRP Discord Bot 4 years 5 days ago #1214277

Bunnyslippers69 wrote: Chuteuk wrote: Hi man can you please release the source code make sure to add a GitHub link your thread Yeah i'm doing that now. Give me like half an hour to clean everything up and add comments. All done vro.	bunnyslippers69 Offline Diamond Boarder Posts: 3539 Thanks received: 1186 Karma: 0
The topic has been locked.

[Release] SSRP Discord Bot 4 years 5 days ago #1214283

I'd recommend splitting commands.js into different files (cleaner coding practice see here for an example).

Ultimatley looks good though, another good practice is avoiding hard coding stuff, in your SSRPItems.cs is the file standing out to me thats hardcoded. Try using a data storing method and creating commands (could be specified to only a certain user or rank that can use this command) where you can add items which should be easier than editing the actual code to add more items. Just a suggestion though I know sometimes people prefer adding it via the code. A config file is also a nice touch to stop people from searching through all your code to modify specific values.

Aidan New Name Banter
Offline
Diamond Boarder
Posts: 3816
Thanks received: 455
Karma: -11

Former Admin on DarkRP
Former Bunny Hop Admin
Former #5 Top poster

The topic has been locked.

[Release] SSRP Discord Bot 4 years 5 days ago #1214286

Aidan New Name Banter wrote:

I'd recommend splitting commands.js into different files (cleaner coding practice see here for an example).

Ultimatley looks good though, another good practice is avoiding hard coding stuff, in your SSRPItems.cs is the file standing out to me thats hardcoded. Try using a data storing method and creating commands (could be specified to only a certain user or rank that can use this command) where you can add items which should be easier than editing the actual code to add more items. Just a suggestion though I know sometimes people prefer adding it via the code. A config file is also a nice touch to stop people from searching through all your code to modify specific values.

Thanks for the feedback, i'll definitely ocnsider cleaning up the Items file. I'll most likely do that after i've got to a point where i'm fairly certain the bot is finished, as it's not a priority at the moment. It does the job well enough for me to not be too concerned about it right now.

bunnyslippers69
Offline
Diamond Boarder
Posts: 3539
Thanks received: 1186
Karma: 0

The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214316

Would be cool.	dusheke dabliqius Offline Gold Boarder Posts: 2044 Thanks received: 461 Karma: -22
The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214319

Huperchild wrote: DG Noah wrote: Would be cool. What would? codabro would	TheFierceOwl Offline Banned ❤Finn❤ Posts: 3453 Thanks received: 541 Karma: -178
The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214320

Has been tested in the JH discord and everyone including myself loves it!	Lerpson Offline Nitro Booster black people should totally be allowed to vote Posts: 4492 Thanks received: 1821 Karma: -20
Jay House number 1 as always The topic has been locked. The following user(s) said Thank You: bunnyslippers69

[Release] SSRP Discord Bot 4 years 4 days ago #1214336

	Skiper Offline Expert Boarder ................ Posts: 900 Thanks received: 345 Karma: -27
what? The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214761

Bunnyslippers69 wrote:

Aidan New Name Banter wrote:

I'd recommend splitting commands.js into different files (cleaner coding practice see here for an example).

Ultimatley looks good though, another good practice is avoiding hard coding stuff, in your SSRPItems.cs is the file standing out to me thats hardcoded. Try using a data storing method and creating commands (could be specified to only a certain user or rank that can use this command) where you can add items which should be easier than editing the actual code to add more items. Just a suggestion though I know sometimes people prefer adding it via the code. A config file is also a nice touch to stop people from searching through all your code to modify specific values.

Thanks for the feedback, i'll definitely ocnsider cleaning up the Items file. I'll most likely do that after i've got to a point where i'm fairly certain the bot is finished, as it's not a priority at the moment. It does the job well enough for me to not be too concerned about it right now.

I decided i'd do both the things you mentioned regardless. You can now add/remove items and printers with commands. Cleaned up the commands, spllit them into different files.

bunnyslippers69
Offline
Diamond Boarder
Posts: 3539
Thanks received: 1186
Karma: 0

The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214817

Bunnyslippers69 wrote:

Aidan New Name Banter wrote:

I'd recommend splitting commands.js into different files (cleaner coding practice see here for an example).

Ultimatley looks good though, another good practice is avoiding hard coding stuff, in your SSRPItems.cs is the file standing out to me thats hardcoded. Try using a data storing method and creating commands (could be specified to only a certain user or rank that can use this command) where you can add items which should be easier than editing the actual code to add more items. Just a suggestion though I know sometimes people prefer adding it via the code. A config file is also a nice touch to stop people from searching through all your code to modify specific values.

Thanks for the feedback, i'll definitely ocnsider cleaning up the Items file. I'll most likely do that after i've got to a point where i'm fairly certain the bot is finished, as it's not a priority at the moment. It does the job well enough for me to not be too concerned about it right now.

I decided i'd do both the things you mentioned regardless. You can now add/remove items and printers with commands. Cleaned up the commands, spllit them into different files.

Good work, although stuff like
if (Context.Message.Author.ToString() != "Bunny#9220") { await Context.Channel.SendMessageAsync("No permission"); }

Tends to be an insecure method. In theory what would stop someone with discord nitro impersonating your account. You'd be better enabling developer mode on discord and getting your userID and using that. (discord.js.org/#/docs/main/stable/class/...ence?scrollTo=userID)

I've proposed a new commit to one of your files using your userid, I'd review it beforehand though as its been a while since I've worked with discord bots.

Aidan New Name Banter
Offline
Diamond Boarder
Posts: 3816
Thanks received: 455
Karma: -11

Former Admin on DarkRP
Former Bunny Hop Admin
Former #5 Top poster

The topic has been locked.

[Release] SSRP Discord Bot 4 years 4 days ago #1214823

Aidan New Name Banter wrote:

Bunnyslippers69 wrote:

Aidan New Name Banter wrote:

I'd recommend splitting commands.js into different files (cleaner coding practice see here for an example).

Ultimatley looks good though, another good practice is avoiding hard coding stuff, in your SSRPItems.cs is the file standing out to me thats hardcoded. Try using a data storing method and creating commands (could be specified to only a certain user or rank that can use this command) where you can add items which should be easier than editing the actual code to add more items. Just a suggestion though I know sometimes people prefer adding it via the code. A config file is also a nice touch to stop people from searching through all your code to modify specific values.

Thanks for the feedback, i'll definitely ocnsider cleaning up the Items file. I'll most likely do that after i've got to a point where i'm fairly certain the bot is finished, as it's not a priority at the moment. It does the job well enough for me to not be too concerned about it right now.

I decided i'd do both the things you mentioned regardless. You can now add/remove items and printers with commands. Cleaned up the commands, spllit them into different files.

Good work, although stuff like
if (Context.Message.Author.ToString() != "Bunny#9220") { await Context.Channel.SendMessageAsync("No permission"); }

Tends to be an insecure method. In theory what would stop someone with discord nitro impersonating your account. You'd be better enabling developer mode on discord and getting your userID and using that. (discord.js.org/#/docs/main/stable/class/...ence?scrollTo=userID)

I've proposed a new commit to one of your files using your userid, I'd review it beforehand though as its been a while since I've worked with discord bots.

Yeah cheers. I didn't plan on leaving it there permanently, just couldn't be arsed doing something different in the moment.

bunnyslippers69
Offline
Diamond Boarder
Posts: 3539
Thanks received: 1186
Karma: 0

The topic has been locked.

[Release] SSRP Discord Bot 3 years 11 months ago #1219697

Added a bunch more commands.	bunnyslippers69 Offline Diamond Boarder Posts: 3539 Thanks received: 1186 Karma: 0
The topic has been locked.

[Release] SSRP Discord Bot 3 years 11 months ago #1219700

rat	Micky Offline Mythical Boarder Posts: 5770 Thanks received: 7912 Karma: -42
The topic has been locked. The following user(s) said Thank You: schnitzel nazi